Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 ignore the manifest uid #242

Merged

Conversation

skeeey
Copy link
Member

@skeeey skeeey commented Aug 1, 2023

Summary

Ignore the manifest uid to avoid UID precondition failed error

Related issue(s)

Fixes #

Signed-off-by: Wei Liu <liuweixa@redhat.com>
@openshift-ci openshift-ci bot requested review from zhiweiyin318 and zhujian7 August 1, 2023 09:02
@skeeey
Copy link
Member Author

skeeey commented Aug 1, 2023

/assign @qiujian16

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (142fd5b) 60.28% compared to head (8b5be06) 60.28%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #242      +/-   ##
==========================================
- Coverage   60.28%   60.28%   -0.01%     
==========================================
  Files         132      132              
  Lines       13563    13563              
==========================================
- Hits         8177     8176       -1     
- Misses       4631     4632       +1     
  Partials      755      755              
Flag Coverage Δ
unit 60.28% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...lers/manifestcontroller/manifestwork_controller.go 64.13% <0.00%> (-1.11%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qiujian16
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiujian16, skeeey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 1, 2023
@openshift-merge-robot openshift-merge-robot merged commit 720ae29 into open-cluster-management-io:main Aug 1, 2023
@skeeey skeeey deleted the ignore-uid branch January 19, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants